Update version to 3.0.0 - #201
Conversation
Signed-off-by: Simon Marty <simon.marty0@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #201 +/- ##
=======================================
Coverage 81.56% 81.56%
=======================================
Files 5 5
Lines 255 255
Branches 24 24
=======================================
Hits 208 208
Misses 40 40
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Claude finished @simonmarty's task in 28s —— View job Code Review — Version bump to 2.0.1Tasks
This PR bumps Assessment ✅
Minor observations (non-blocking)
Verdict: Looks good to merge. 👍 |
There was a problem hiding this comment.
Is the major version bump still going to happen because of the API change from this PR?
Signed-off-by: Simon Marty <simon.marty0@gmail.com>
|
I think you mean #200 but good catch this does need to be a major version bump. |
|
Claude finished @simonmarty's task in 1m 18s —— View job Version bump review — major bump confirmed correct ✅
You're right, and the branch already reflects the fix — commit Why a major bump is correctPR #200 "Fix lock contention" is not a pure bug fix — it changes the public API surface. The current interface confirms it: // ISecretsManagerCache.cs:34
Task<SecretCacheItem> GetCachedSecret(string secretId, CancellationToken cancellationToken = default);
The version also propagates correctly: Non-blocking follow-ups
Verdict: |
Description
Why is this change being made?
What is changing?
Related Links
Testing
How was this tested?
When testing locally, provide testing artifact(s):
Reviewee Checklist
Update the checklist after submitting the PR
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
Reviewer Checklist
All reviewers please ensure the following are true before reviewing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.