Skip to content

Matrix dotnet build #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonmarty wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Matrix dotnet build #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4c7fba
Matrix dotnet build
simonmarty Apr 2, 2026
87afe0e
Merge branch 'master' into matrix
simonmarty Jul 8, 2026
5dbd8bb
Address comments
simonmarty Jul 9, 2026
2427b23
Merge branch 'master' into matrix
simonmarty Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions .github/workflows/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,35 @@ permissions:

jobs:
build:
runs-on: windows-latest
name: build (${{ matrix.runner }}, ${{ matrix.framework }})
strategy:
fail-fast: false
matrix:
include:
- runner: ubuntu-latest
framework: net8.0
- runner: ubuntu-latest
framework: net10.0
- runner: windows-latest
framework: net8.0
- runner: windows-latest
framework: net10.0
- runner: windows-latest
framework: net48
runs-on: ${{ matrix.runner }}

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Install .NET
uses: actions/setup-dotnet@v4
uses: actions/setup-dotnet@v5
with:
dotnet-version: |
8
10
- name: Install .NET Framework (add MSBuild to Path)
uses: microsoft/setup-msbuild@v2
if: runner.os == 'Windows'
uses: microsoft/setup-msbuild@v3
with:
msbuild-architecture: x64
- name: Restore dependencies
Expand All @@ -33,9 +50,9 @@ jobs:
- name: Test
# Strong name requires disabling xUnit app domains in order to get coverage using coverlet
# https://github.com/MarcoRossignoli/coverlet/blob/master/Documentation/KnownIssues.md#tests-fail-if-assembly-is-strong-named
run: dotnet test --no-build --verbosity normal --collect:"XPlat Code Coverage" test/Amazon.SecretsManager.Extensions.Caching.UnitTests -- RunConfiguration.DisableAppDomain=true
run: dotnet test --no-build --verbosity normal --collect:"XPlat Code Coverage" test/Amazon.SecretsManager.Extensions.Caching.UnitTests --framework ${{ matrix.framework }} -- RunConfiguration.DisableAppDomain=true
- name: Codecov
uses: codecov/codecov-action@v5
uses: codecov/codecov-action@v6
with:
directory: test/Amazon.SecretsManager.Extensions.Caching.UnitTests/TestResults
fail_ci_if_error: true
Expand Down
2 changes: 1 addition & 1 deletion ....Extensions.Caching.IntegTests/Amazon.SecretsManager.Extensions.Caching.IntegTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net8.0;net48</TargetFrameworks>
<TargetFrameworks>net8.0;net10.0;net48</TargetFrameworks>
<IsPackable>false</IsPackable>
<DisableImplicitNamespaceImports>true</DisableImplicitNamespaceImports>
<SignAssembly>true</SignAssembly>
Expand Down
2 changes: 1 addition & 1 deletion ...er.Extensions.Caching.UnitTests/Amazon.SecretsManager.Extensions.Caching.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net8.0;net48</TargetFrameworks>
<TargetFrameworks>net8.0;net10.0;net48</TargetFrameworks>
<IsPackable>false</IsPackable>
<DisableImplicitNamespaceImports>true</DisableImplicitNamespaceImports>
<SignAssembly>true</SignAssembly>
Expand Down
Loading