Fix wall clock reset issue - #131
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
derik01
reviewed
Aug 3, 2026
derik01
reviewed
Aug 3, 2026
derik01
approved these changes
Aug 3, 2026
i-am-SR
approved these changes
Aug 3, 2026
i-am-SR
left a comment
Contributor
There was a problem hiding this comment.
nit: No test validates that a wall-clock jump backward is caught by the monotonic side. This is the primary benefit of the monotonic check and would strengthen the test suite.
Contributor
Author
Yeah, what you said is true, but this is indirectly tested in the tests from line 129-247 when only the monotonic time was moved forward and the wall-clock was frozen in time. Sorry if it was confusing at all, but I wrote those original methods without the AdvanceWall method and I forgot to go back and change them so that it made more sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why is this change being made?
What is changing?
Testing
How was this tested?
When testing locally, provide testing artifact(s):
N/A
Reviewee Checklist
Update the checklist after submitting the PR
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
Reviewer Checklist
All reviewers please ensure the following are true before reviewing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.