Skip to content

Add integ workflow, build on oldstable - #130

Open
simonmarty wants to merge 3 commits into
aws:masterfrom
simonmarty:integ
Open

Add integ workflow, build on oldstable#130
simonmarty wants to merge 3 commits into
aws:masterfrom
simonmarty:integ

Conversation

@simonmarty

Copy link
Copy Markdown
Contributor

Description

Why is this change being made?

  1. We do not build the library on the old stable version of Go at this time. Go supports two versions concurrently.
  2. We do not have a way to automatically run integration tests.

What is changing?

  1. Matrix on ("stable", "oldstable") to build Go.
  2. Run integration tests using a GH actions workflow.
  3. Add a workflow to remove the safe-to-test label when new commits are pushed.

Related Links

  • Issue #, if available:

Testing

How was this tested?

  1. Tested on fork.

When testing locally, provide testing artifact(s):

  1. https://github.com/simonmarty/aws-secretsmanager-caching-go/actions/runs/23772898591
  2. https://github.com/simonmarty/aws-secretsmanager-caching-go/actions/runs/23772898597

Reviewee Checklist

Update the checklist after submitting the PR

  • I have reviewed, tested and understand all changes
    If not, why:
  • I have filled out the Description and Testing sections above
    If not, why:
  • Build and Unit tests are passing
    If not, why:
  • Unit test coverage check is passing
    If not, why:
  • Integration tests pass locally
    If not, why:
  • I have updated integration tests (if needed)
    If not, why:
  • I have ensured no sensitive information is leaking (i.e., no logging of sensitive fields, or otherwise)
    If not, why:
  • I have added explanatory comments for complex logic, new classes/methods and new tests
    If not, why:
  • I have updated README/documentation (if needed)
    If not, why:
  • I have clearly called out breaking changes (if any)
    If not, why:

Reviewer Checklist

All reviewers please ensure the following are true before reviewing:

  • Reviewee checklist has been accurately filled out
  • Code changes align with stated purpose in description
  • Test coverage adequately validates the changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@simonmarty
simonmarty requested a review from a team as a code owner March 30, 2026 23:36
@codecov

codecov Bot commented Mar 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.59%. Comparing base (5be93e0) to head (b789f54).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   95.80%   96.59%   +0.79%     
==========================================
  Files           7        7              
  Lines         286      294       +8     
==========================================
+ Hits          274      284      +10     
+ Misses         10        8       -2     
  Partials        2        2              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant