Fix transfermanager multipart uploads for seekable bodies - #3468
Open
goutamadwant wants to merge 1 commit into
Open
Fix transfermanager multipart uploads for seekable bodies#3468goutamadwant wants to merge 1 commit into
goutamadwant wants to merge 1 commit into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3453
This updates
UploadObjectso multipart uploads for seekable bodies use section readers for each part instead of copying every part through the transfermanager buffer pool.Seekable bodies are detected when the input implements both
io.ReaderAtandio.Seeker. In that path, each multipart part is served withio.NewSectionReader, including when the body starts from a non-zero current offset. The existing buffered path is still used for non-seekable readers.Validation:
go test . -run TestUploadOrderMultiSeekableBodyUsesSectionReaders -count=1go test ./... -count=1Changelog
No changelog entry added. Maintainers will handle the changelog entry.