Skip to content

config: accept login_session profiles as an assume role source_profile #3447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alext wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −0
Open

config: accept login_session profiles as an assume role source_profile #3447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/shared_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1463,6 +1463,7 @@ func (c *SharedConfig) hasCredentials() bool {
case len(c.CredentialSource) != 0:
case len(c.CredentialProcess) != 0:
case len(c.WebIdentityTokenFile) != 0:
case len(c.LoginSession) != 0:
case c.hasSSOConfiguration():
case c.Credentials.HasKeys():
default:
Expand Down
13 changes: 13 additions & 0 deletions config/shared_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,19 @@ func TestNewSharedConfig(t *testing.T) {
RoleARN: "assume_role_wo_creds_role_arn",
},
},
"Assume role with login session source profile": {
ConfigFilenames: []string{testConfigFilename},
Profile: "assume_role_w_login_session",
Expected: SharedConfig{
Profile: "assume_role_w_login_session",
RoleARN: "assume_role_w_login_session_role_arn",
SourceProfileName: "login_session_creds",
Source: &SharedConfig{
Profile: "login_session_creds",
LoginSession: "login_session_creds_session",
},
},
},
"Invalid INI file": {
ConfigFilenames: []string{filepath.Join("testdata", "shared_config_invalid_ini")},
Profile: "profile_name",
Expand Down
7 changes: 7 additions & 0 deletions config/testdata/shared_config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,13 @@ aws_secret_access_key = assume_role_w_creds_secret
role_arn = assume_role_wo_creds_role_arn
source_profile = assume_role_wo_creds

[profile login_session_creds]
login_session = login_session_creds_session

[profile assume_role_w_login_session]
role_arn = assume_role_w_login_session_role_arn
source_profile = login_session_creds

[profile valid_arn_region]
s3_use_arn_region=true

Expand Down
Loading