ec2: add handwritten paginators for VPC Encryption Control APIs - #3435
Open
pedrorfdez wants to merge 1 commit into
Open
ec2: add handwritten paginators for VPC Encryption Control APIs#3435pedrorfdez wants to merge 1 commit into
pedrorfdez wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3232
What was changed
Added handwritten paginators for the two VPC Encryption Control read APIs that support pagination but were missing paginator implementations:
NewDescribeVpcEncryptionControlsPaginatorNewGetVpcResourcesBlockingEncryptionEnforcementPaginatorBoth operations already have
NextToken+MaxResultson their input/output structs. The root cause of the missing paginators is the absence of thesmithy.api#paginatedtrait in the upstream EC2 service model. Since the model file and generated source files are off-limits to direct modification per the contributing guidelines, this follows the establishedhandwritten_paginators.gopattern used inservice/s3,service/dynamodb,service/kinesis, andservice/route53.Testing
Unit tests added in
service/ec2/handwritten_paginators_test.gocovering:StopOnDuplicateTokenbehaviourMaxResults/Limitpropagation across pagesVpcIdfield preservation across pages (required field onGetVpcResourcesBlockingEncryptionEnforcement)