Conversation
There was a problem hiding this comment.
Header files should be in include/
There was a problem hiding this comment.
You should use #pragma once like what you did above
There was a problem hiding this comment.
// Created by Narahari, Vinay on 6/5/26.
yeahhhh, i dont think we want this comment
There was a problem hiding this comment.
Is this an empty class? if we need to add members in the future we should make this into a pimpl
There was a problem hiding this comment.
we should add IsSuccess()/GetError() on the response to let customer know whether their transfer failed or succeeded
There was a problem hiding this comment.
TM v1 uses a private constructor and static shared_ptr<TransferManager> Create() factory, which enables shared_from_this internally to prevent destruction while async CRT callbacks are in flight. Making this constructor public and deleting moves locks you out of that pattern later without a breaking API change. We should use a factory here
2 participants
Issue #, if available:
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.