Skip to content

add missing include - #3840

Merged
sbiscigl merged 1 commit into
mainfrom
missing-include
Jun 8, 2026
Merged

add missing include#3840
sbiscigl merged 1 commit into
mainfrom
missing-include

Conversation

@sbiscigl

@sbiscigl sbiscigl commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Issue #, if available:

#3838

Description of changes:

adds missing include that breaks musl toolchains

replicated/verified fix with

FROM alpine:3.23

RUN apk add --no-cache build-base cmake ninja git curl-dev openssl-dev zlib-dev

RUN git clone \
        --depth 1 \
        --branch missing-include \
        --recurse-submodules \
        https://github.com/aws/aws-sdk-cpp.git

RUN cd aws-sdk-cpp && \
        mkdir build && \
        cd build && \
        cmake -G Ninja -DBUILD_ONLY="core" .. && \
        cmake --build .

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl
sbiscigl marked this pull request as ready for review June 8, 2026 14:20
@sbiscigl
sbiscigl enabled auto-merge June 8, 2026 14:59
@sbiscigl
sbiscigl added this pull request to the merge queue Jun 8, 2026
Merged via the queue into main with commit f3a5a9c Jun 8, 2026
5 of 7 checks passed
@sbiscigl
sbiscigl deleted the missing-include branch June 8, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants