Skip to content

Fix race conditions in samples and service tests - #748

Merged
sfod merged 5 commits into
mainfrom
fix-race-conditions
Sep 11, 2024
Merged

Fix race conditions in samples and service tests#748
sfod merged 5 commits into
mainfrom
fix-race-conditions

Conversation

@sfod

@sfod sfod commented Sep 10, 2024

Copy link
Copy Markdown
Contributor

Issue #, if available:

There are race conditions in Fleet provisioning service tests and Secure tunnel sample (caught by this PR #703).

Description of changes:

  • I recently fixed a race condition in Fleet provisioning sample, so I reused that code in Fleet provisioning service tests.
  • Secure tunnel sample used sleep to sync two threads, I added a promise.
  • Additional change: use std::unique_ptr instead of raw pointers in samples.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Comment thread servicetests/tests/FleetProvisioning/main.cpp Outdated
@sfod
sfod merged commit 6bf060a into main Sep 11, 2024
@sfod
sfod deleted the fix-race-conditions branch September 11, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants