-
Notifications
You must be signed in to change notification settings - Fork 11
fix: operations always return deserialized result #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,9 +144,11 @@ private void checkpointStarted() { | |
| } | ||
|
|
||
| private void handleStepSucceeded(T result) { | ||
| var serializedResult = serializeAndDeserializeResult(result); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit:
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. any suggestions?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| // Send SUCCEED | ||
| var successUpdate = | ||
| OperationUpdate.builder().action(OperationAction.SUCCEED).payload(serializeResult(result)); | ||
| OperationUpdate.builder().action(OperationAction.SUCCEED).payload(serializedResult.serialized()); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we using serialized here because we re-execute step during replay? why can't we use raw then?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| // sendOperationUpdate must be synchronous here. When waiting for the return of this call, | ||
| // the context threads waiting for the result of this step operation will be wakened up and registered. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
T resultis this required?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, when caching large payload