[mtrl] Fix undefined STAGE in S3_TRAINING_DATA path - #4904
Merged
aviruthen merged 1 commit intoJul 30, 2026
Merged
Conversation
…lder The 3rd cell of mtrl_finetuning_example_notebook_v3_prod.ipynb set S3_TRAINING_DATA using an f-string that referenced an undefined STAGE variable and an internal `-rftjob-input` bucket pattern left over from when MTRL was tested in gamma/prod. Executing the cell raised `NameError: name 'STAGE' is not defined`. Replace it with a customer-facing placeholder S3 URI, consistent with the convention used in the sibling sft_finetuning notebook, so users (and the notebook test engine) can substitute their own dataset path.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
lucasjia-aws
approved these changes
Jul 30, 2026
aviruthen
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The 3rd code cell of
model-customization-examples/mtrl_finetuning_example_notebook_v3_prod.ipynbfails to execute withNameError: name 'STAGE' is not defined.The cell set the training-data path using an f-string referencing an undefined
STAGEvariable and an internal-rftjob-inputbucket pattern:REGIONandCUSTOMER_ACCOUNTare defined earlier in the notebook, butSTAGEis not — it was a leftover from when MTRL was tested internally in gamma/prod. An SA following the MTRL best-practices blog and this notebook hit this error.Fix
Replace the internal STAGE-based path with a customer-facing placeholder S3 URI, matching the convention already used in the sibling
sft_finetuning_example_notebook_pysdk_prod_v3.ipynb:Customers (and the notebook test engine, which substitutes a real dataset S3 URI) can now fill in their own dataset path.
Notes
NotebookTestEnginebranch so PR checks run E2E.