fix: skip missing authorized_keys cleanup paths#718
Open
nanookclaw wants to merge 1 commit into
Open
Conversation
fb98c06 to
e0077b9
Compare
Author
|
Rebased Verification after the rebase:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #709.
This updates the per-user
authorized_keyscleanup so thefindcommand starts at the user home directory and filters to.ssh/authorized_keys, instead of using the file itself as thefindstarting path. When a user does not have that file,findnow exits successfully with no matches instead of failing the whole cleanup script underset -e.The follow-up verification loop is unchanged, so the script still fails if an
authorized_keysfile remains after cleanup.Testing:
bash -n scripts/cleanup.shgit diff --checkfindsmoke check withset -efor both missing and present.ssh/authorized_keys