Adding parameters for recipe and GDK config custom file selection and new Push command for local deployment - #119
Open
iakko wants to merge 9 commits into
Open
Adding parameters for recipe and GDK config custom file selection and new Push command for local deployment#119iakko wants to merge 9 commits into
iakko wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Adding the following capabilities:
Adding new optional parameters to the
component buildcommand:[-c GDK_CONFIG]: to specify a custom gdk-config.json file.[-r RECIPE]: to specify a custom recipe.json file.[-u BUILD_DIR]: to specify a custom greengrass-build folder for built artifact/recipe.Adding new optional parameters to the
component publishcommand:[-c GDK_CONFIG]: to specify a custom gdk-config.json file.[-u BUILD_DIR]: to specify a custom greengrass-build folder for built artifact/recipe. Note that the recipe file will be searched into the BUILD_DIR and not in the working directory. It will also respect theCOMPONENT_NAMEandCOMPONENT_VERSIONformat in case they are provided (see below), or the defaultrecipe.{json,yaml}if not.[-n COMPONENT_NAME]: to specify a custom component name to be used to create the built version of the recipe file. This is useful in case the BUILD_DIR contains an artifact produced by thecomponent pushcommand (see below for details on this new command).[-w COMPONENT_VERSION]: to specify a custom component version to be used to create the built version of the recipe file. This is useful in case the BUILD_DIR contains an artifact produced by thecomponent pushcommand (see below for details on this new command).Adding a new
component pushcommand for local deployment of the final artifact. This command is useful in case you want to avoid deploying the component through the standard process which requires to pass through the cloud even for local testing. The target folder will contain the artifact with proper artifacts folder's structure and the renamed recipe file with<component_name>-<component_version>.<extention>. This command will also respect the "NEXT_PATCH" directive in the gdk-config file, checking the destination folder structure, calculating the proper next version according to existing version folders (as it does right now with thecomponent publishcommand).The command will have the following parameters:
[-h]: for help[-d]:for debugging messages:[-v]: version (global parameter)[-c GDK_CONFIG]: to specify a custom gdk-config.json file.[-u BUILD_DIR]: to specify a custom greengrass-build folder for built artifact/recipe to be pushed.-e DESTINATION: the target destination of the component location. The format of this parameter must start with file://<local_destination_path> because the idea is to be able to use an S3 bucket in case we want to centralize component in a remote location usings3://<bucket_name>/<bucket_folder>. This last option is not implemented yet.Why is this change necessary:
This will enable local testing in case of a local Greengrass instance.
How was this change tested:
Using the standard commands as per current implementation (1.1.0), everything will work as usual (allowing retrofitting). In case you want to test the new local location, you can do the following:
gdk component build -d -c gdk-config.json -r recipe.json -u greengrass-buildgdk component push -u greengrass-build -e file:///tmp/ggtree /tmp/gg(should contain the standard component structure withartifactsandrecipesfolders. Therecipesone should contain the<component_name>-<component_version>.<extention>file and theartifcatsdirectory should contain the<version>properly calculated folder(or 1.0.0 if new) with the artifact inside.gdk component publish -d -c gdk-config.json -u /tmp/gg -n <component_name> -w <component_version>.Any additional information or context required to review the change:
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.