fix: correct vfx_pipeline build docs and frame/publish edge cases - #264
Merged
crowecawcaw merged 2 commits intoJul 30, 2026
Merged
Conversation
Follow-up to aws-deadline#258, addressing issues found in post-merge review and local testing. - Documented `rattler-build build` commands failed as written: the recipe's post-build test needs Blender (only in the farm's deadline-cloud channel), so the build exited non-zero and published an empty channel. Add `--test skip` (with an explanation) to the two README build commands and the conda_channel README, and fix the local `conda create` test command to include the deadline-cloud channel that provides Blender. - Fail fast when FLOW_PROJECT_ID is the placeholder 0 and publishing is enabled. Previously "0" passed the required-variable check, so a shot rendered every frame (real farm cost) before PublishToFlow failed against project 0. - Handle a single-frame range (e.g. FrameRange=5) in render_shot.py, encode_movie.py, and make_thumbnail.py instead of raising a ValueError on the `start-end` unpack. OpenJD accepts a bare integer as a valid range. - Clarify in the `studio-pipe submit` help that pass-through args for `deadline bundle submit` go after a `--` separator (e.g. `-- --yes`). - Replace the bundle README's local-render snippet, which failed verbatim (it enabled the add-on without setting BLENDER_USER_SCRIPTS and used unrunnable paths), with a pointer to the working top-level walkthrough. Note the tested Blender version (4.2+). Signed-off-by: Stephen Crowe <6042774+crowecawcaw@users.noreply.github.com>
crowecawcaw
force-pushed
the
fix/vfx-pipeline-followup
branch
from
July 30, 2026 15:13
c68a81e to
b8f7ecb
Compare
crowecawcaw
marked this pull request as ready for review
July 30, 2026 15:19
crowecawcaw
enabled auto-merge (squash)
July 30, 2026 20:20
leon-li-inspire
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #258. A post-merge review surfaced a few issues in the newly added
job_bundles/vfx_pipelinesample; this PR fixes them. All changes are confined to that sample.Fixes
rattler-build buildcommand in the sample README (twice) and theconda_channelREADME runs the recipe's post-build test, which must solveblender— available only in the farm'sdeadline-cloudchannel, not on a workstation. The build exited non-zero and left no package, so the next step published an empty channel. Added--test skip(with an explanation) to all three build commands, and fixed the localconda createtest command to include thedeadline-cloudchannel that provides Blender.project.yamlshipsproject_id: 0. Because"0"is non-empty it passed the preSubmission hook's required-variable check, so a shot with publishing enabled rendered every frame (real farm cost) and only then failed inPublishToFlowagainst project 0. The hook now rejectsFlowProjectId == 0at submit time with a clear message when publishing is enabled.render_shot.py,encode_movie.py, andmake_thumbnail.pydidstart, end = frame_range.split("-"), which raisedValueErrorfor a bare single frame likeFrameRange=5(a valid OpenJD range). They now handle the no--case. (Step ranges and comma lists remain unsupported, as before.)studio-pipe submitpass-through help. Clarified that extra args fordeadline bundle submitgo after a--separator (e.g.-- --yes), matching the README and how argparse routes them.Verification
openjd checkpasses on the template.scripts/validate_repository.pypasses (unit tests + local link check).1-48,5, and1-1.Opening as a draft.
--addon-modulebut never setBLENDER_USER_SCRIPTS, and used unrunnable paths (barescripts/...from a CWD wherestudio/is two levels up, plus a.../placeholder). Replaced it with a pointer to the working top-level walkthrough, and noted the tested Blender version (4.2+). Found by running every documented step locally.