chore(deps): update ruff requirement from ==0.15.* to ==0.16.* - #154
Conversation
8710c68 to
786d91a
Compare
Updates the requirements on [ruff](https://github.com/astral-sh/ruff) to permit the latest version. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.15.0...0.16.0) --- updated-dependencies: - dependency-name: ruff dependency-version: 0.16.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
786d91a to
eab051e
Compare
| [tool.ruff.lint] | ||
| ignore = ["E501"] | ||
|
|
||
| [tool.ruff.lint.per-file-ignores] |
There was a problem hiding this comment.
These new suppressions appear to be no-ops: [tool.ruff.lint] only sets ignore = ["E501"] and never sets select / extend-select, so ruff runs with its default rule set (E4, E7, E9, F). None of N999, TRY002, BLE001, or B008 are in that set, so:
- every entry in this
per-file-ignoresblock ignores a rule that is never emitted, [tool.ruff.lint.flake8-bugbear] extend-immutable-callshas nothing to affect (B008 is off),- the two new
# noqa: BLE001comments added in this PR (VRED_RenderScript_DeadlineCloud.py:531,ui/components/scene_settings_callbacks.py:131) suppress a rule that is not enabled.
The risk is that this reads as "these rules are enforced with documented exceptions," when in fact none of them are checked. Either add the corresponding rules to select (and then these suppressions become load-bearing), or drop the config block and the noqa markers so the file reflects what actually runs.
| for mapping in data.get(self.PATH_MAPPING_RULES_FIELD) | ||
| ] | ||
| except Exception as exc: | ||
| except (OSError, json.JSONDecodeError, TypeError) as exc: |
There was a problem hiding this comment.
Narrowing this from except Exception changes behavior for at least two reachable cases in the try body:
data.get(self.PATH_MAPPING_RULES_FIELD)returnsNonewhen the key is absent, and iteratingNoneraisesTypeError— covered. But if the value is a list of non-dicts (e.g. strings),PathMappingRule(**mapping)raisesTypeError— also covered. If a mapping dict has extra/missing keys,PathMappingRule(**mapping)raisesTypeErrortoo. So far so good.AttributeErroris not covered: if the JSON top level is a list or scalar,data.get(...)raisesAttributeErrorand now propagates out ofload_path_mapping_rules.
AttributeError also escapes from self.render_parameters.PathMappingRulesFile if that parameter is absent from the render parameters dict (DynamicKeyValueObject only sets attributes present in the dict), which previously returned False and let rendering continue unmapped.
Since this is called from map_path (line 413) during init_file_references, an escaping exception now aborts the whole render via the outer handler rather than degrading to unmapped paths. Consider adding AttributeError to the tuple, or keeping the broad catch here.
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Updates the requirements on ruff to permit the latest version.
Release notes
Sourced from ruff's releases.
... (truncated)
Changelog
Sourced from ruff's changelog.
... (truncated)
Commits
a2635fdBump 0.16.0 (#27136)3433449[ty] Reuse full call diagnostics for implicit setter calls (#27115)2240070Reflectruff: ignoreand--add-ignorestabilization in documentation (#27...17ef711Stabilize--add-ignore(#27125)ef912bbAdd newly stabilized rules to defaults (#27055)b30f040Stabilize new default rules (#27035)bcd70c5Exclude Markdown files fromformat-devruns (#27052)87e51e2Fixformat --checkspans for syntax errors (#27045)afe2723[flake8-gettext] Stabilize qualified-name and built-in binding resolution (...a9702d8[flake8-bandit] Stabilize string literal binding resolution (S310) (#26944)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)