chore: remove CodeArtifact publish step and twine - #282
Closed
crowecawcaw wants to merge 1 commit into
Closed
Conversation
crowecawcaw
force-pushed
the
remove-codeartifact-publish
branch
2 times, most recently
from
July 28, 2026 20:12
8104dd2 to
71a5d6f
Compare
This package is no longer published to PyPI or CodeArtifact. The submitter is a KeyShot script and the adaptor is bundled into it; releases attach build artifacts to the GitHub release rather than publishing a distributable package. - Delete pipeline/publish.sh (the twine upload to CodeArtifact) - Drop the twine install from pipeline/build.sh - Remove twine from requirements-testing.txt Signed-off-by: Stephen Crowe <6042774+crowecawcaw@users.noreply.github.com>
crowecawcaw
force-pushed
the
remove-codeartifact-publish
branch
from
July 28, 2026 20:12
71a5d6f to
ea5d833
Compare
crowecawcaw
marked this pull request as ready for review
July 28, 2026 20:52
Contributor
Author
|
Closing. Script is still used internally for the moment, even though it doesn't accomplish anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This package is no longer published to PyPI or CodeArtifact, so the
twine-based publish path is dead code. The KeyShot submitter is a script (src/submitter.py) and the adaptor is bundled into it; the release workflow attaches build artifacts to the GitHub release rather than publishing a distributable package.Removes:
pipeline/publish.sh— thetwine upload --repository codeartifactstep (the only thing that published anything)pip install --upgrade twinefrompipeline/build.sh(twine was only needed for the publish step; the script still runs lint/test/build for CodeBuild)twine == 6.*fromrequirements-testing.txtWhy
Confirmed nothing publishes to PyPI/CodeArtifact anymore:
reusable_prerelease→reusable_release) builds and uploads artifacts to the GitHub release — no PyPI upload.pipeline/publish.shwas the soletwine upload, and it isn't wired into any GitHub Actions workflow.Note: this also makes the open dependabot bump (twine 6→7, #281) moot.
Testing
grep -rn twineacross the repo returns no matches after the change.pipeline/build.shstill performs lint/test/build via thecodebuildhatch env; only the twine install line was removed.