Skip to content

feat: add rotation management support to Secret resource - #69

Open
michaelhtm wants to merge 2 commits into
aws-controllers-k8s:mainfrom
michaelhtm:feat/rotation-support
Open

feat: add rotation management support to Secret resource#69
michaelhtm wants to merge 2 commits into
aws-controllers-k8s:mainfrom
michaelhtm:feat/rotation-support

Conversation

@michaelhtm

@michaelhtm michaelhtm commented May 26, 2026

Copy link
Copy Markdown
Member

Issue #, if available:

Description of changes:
Adds RotationEnabled, RotationLambdaARN, and RotationRules fields to the
Secret spec sourced from DescribeSecret. Uses compare.is_ignored with a
custom delta that only fires when desired is non-nil, so existing secrets
are not disrupted. When RotationEnabled is explicitly set to false, the
controller calls CancelRotateSecret. When set to true, it calls
RotateSecret with the specified rules and lambda ARN.

Resolves aws-controllers-k8s/community#2713

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
ack-prow Bot requested a review from gustavodiaz7722 May 26, 2026 21:17
@ack-prow

ack-prow Bot commented May 26, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow
ack-prow Bot requested a review from sapphirew May 26, 2026 21:17
@ack-prow ack-prow Bot added the approved label May 26, 2026
@michaelhtm michaelhtm changed the title Feat/rotation support feat: add rotation management support to Secret resource May 26, 2026
Adds RotationEnabled, RotationLambdaARN, and RotationRules fields to the
Secret spec sourced from DescribeSecret. Uses compare.is_ignored with a
custom delta that only fires when desired is non-nil, so existing secrets
are not disrupted. When RotationEnabled is explicitly set to false, the
controller calls CancelRotateSecret. When set to true, it calls
RotateSecret with the specified rules and lambda ARN.
@michaelhtm
michaelhtm force-pushed the feat/rotation-support branch from ee24a35 to 2b804e7 Compare June 26, 2026 01:22
@ack-prow

ack-prow Bot commented Jun 26, 2026

Copy link
Copy Markdown

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
secretsmanager-verify-attribution 2b804e7 link false /test secretsmanager-verify-attribution

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@michaelhtm

Copy link
Copy Markdown
Member Author

/label release/minor

@ack-prow ack-prow Bot added the release/minor Indicates this PR should trigger a minor version release on merge. label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved release/minor Indicates this PR should trigger a minor version release on merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Secrets Rotation in Secrets ACK Controller

1 participant