feat: add rotation management support to Secret resource - #69
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds RotationEnabled, RotationLambdaARN, and RotationRules fields to the Secret spec sourced from DescribeSecret. Uses compare.is_ignored with a custom delta that only fires when desired is non-nil, so existing secrets are not disrupted. When RotationEnabled is explicitly set to false, the controller calls CancelRotateSecret. When set to true, it calls RotateSecret with the specified rules and lambda ARN.
ee24a35 to
2b804e7
Compare
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label release/minor |
Issue #, if available:
Description of changes:
Adds RotationEnabled, RotationLambdaARN, and RotationRules fields to the
Secret spec sourced from DescribeSecret. Uses compare.is_ignored with a
custom delta that only fires when desired is non-nil, so existing secrets
are not disrupted. When RotationEnabled is explicitly set to false, the
controller calls CancelRotateSecret. When set to true, it calls
RotateSecret with the specified rules and lambda ARN.
Resolves aws-controllers-k8s/community#2713
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.