feat: add TAG105 to block tagging.taggable changing from false to true - #114
Merged
Conversation
Adds the inverse of TAG101: flipping `tagging.taggable` from false to true is now reported as a breaking change. The taggable branch of `ensure_taggable_not_changed` asserted `this.old_value == true` as a bare clause with no custom message attached. A false -> true flip therefore failed that clause, but the finding carried an empty message and was dropped by runner.py, which skips message-less checks. The rule failed silently - the violation showed up in neither non_compliant, compliant, nor skipped. Turning old_value into a `when` condition surfaces the new TAG105 finding and leaves TAG101 behavior (check id, message and path) unchanged.
The eslint hook has been failing `pre-commit run --all-files` with
Failed to load plugin '@typescript-eslint' declared in
'vscode-extension/.eslintrc.json': Cannot read properties of
undefined (reading 'Intrinsic')
typescript is an *optional* peer dependency of
@typescript-eslint/eslint-plugin, so npm does not reliably install it
into the hook's isolated environment - but ts-api-utils, which the
plugin pulls in transitively, requires it at load time. Declaring
typescript@5.3.3 explicitly fixes the plugin load. 5.3.3 satisfies the
`^5.0.0` that vscode-extension/package.json already pins.
Verified with the hook's exact versions (eslint 8.56.0, parser and
plugin 6.21.0) plus typescript 5.3.3: eslint exits 0 over every
vscode-extension .js/.ts file and --fix rewrites nothing, so no source
changes are needed.
jingsi-chen
approved these changes
Aug 26, 2026
agarikana
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
TAG101blockstagging.taggablegoing fromtruetofalse, but the inverse transition (false->true) had no check.Description of changes
Adds
TAG105-"tagging.taggable MUST NOT change from false to true".This required restructuring the
taggablebranch ofensure_taggable_not_changedrather than just appending a clause. The branch assertedthis.old_value == trueas a bare clause with no custom message attached (the<< ... >>block binds to the clause that precedes it, i.e.this.new_value != false). Because clauses in a block are ANDed, afalse -> trueflip already failed the rule today - but the resulting finding carried an empty message and was silently dropped byrunner.py, which skips message-less checks. The violation surfaced in neithernon_compliant,compliant, norskipped.Turning
old_valueinto awhencondition fixes that and lets each direction carry its own check id:TAG101behavior is unchanged - same check id, message and reported path (/tagging/changed/0/new_value).Testing
Verified against the engine for every transition:
false -> truereportsTAG105only;true -> falsereportsTAG101only; no-op and newly-addedtaggingblocks report nothing;TAG102/TAG104unaffected. Two integ cases added (the minimal flip, plus the realistic case where a provider turnstaggableon while addingtagOnCreate/tagUpdatable/cloudFormationSystemTags/tagPropertyin the same revision).Full suite
96 -> 98passing,black==22.3.0clean,pylint==2.15.10at 10.00/10.Follow-up (not in this PR)
TAG102(tagOnCreate) andTAG103(cloudFormationSystemTags) still have the same message-less-clause pattern, so afalse -> trueflip on either makes the rule fail with nothing reported. Happy to apply the same two-line restructure in a separate PR.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.