Updated TimeoutInMinutes property for CodeBuild project - #35
Open
js37 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: None
Description of changes:
AWS::CodeBuild::ProjectTimeoutInMinuteshas a manual patch pinningmaximum: 480. AWS [raised the build timeout limit to 36 hours (2160 minutes) in June 2024](https://aws.amazon.com/about-aws/whats-new/2024/06/aws-codebuild-build-timeout-limit-increased-36-hours/), so the patch now rejects valid templates: any build timeout above 8 hours fails validation.This corrects the value to 2160.
QueuedTimeoutInMinutesstays at 480, which is still accurate. The two properties have different limits and target different shapes in the CodeBuild API model:timeoutInMinutes→BuildTimeOut,smithy.api#range{min: 5, max: 2160}queuedTimeoutInMinutes→TimeOut,smithy.api#range{min: 5, max: 480}Why the value is updated rather than the override removed
PR #15 removed a stale Lambda
Timeout/maximuminstead of updating it, on the grounds that the smithy model now supplies the correct value. That approach does not work for CodeBuild.The smithy generator only walks properties reachable from a create operation, which it derives from
handlers.create.permissions(_get_create_operations,generators/smithy.py). The publishedaws-codebuild-project.jsonhas an emptycreate.permissionsarray, so the generator matches zero paths for this resource and never writes asmithy.jsonfor it:The base schema is also unbounded (
TimeoutInMinutes: {"type": "integer"}). Deleting the override would therefore leave the property with nomaximumat all rather than falling back to 2160, and cfn-lint would stop flagging out-of-range values entirely. For the same reason, all four entries in thismanual.jsonare load-bearing and none are redundant with smithy.Verification
Assembled the schema locally with provider patches applied first, matching the build order:
Existing tests pass, including
TestPatchConflicts::test_no_manual_smithy_value_conflicts.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.