Fix: telemetry decorator wiring - #442
Merged
Merged
Conversation
…orkerManager Wire telemetry correctly using the @telemetry() decorator instead of manual ScopedTelemetry instantiation to match the pattern used in CfnLintService and GuardService.
Infrastructure failures (worker crashes, uninitialized worker) are tracked separately and should not count against cfn-lint availability. Only actual cfn-lint failures should impact availability metrics.
Mount failures are infrastructure issues tracked separately as mount.fault and should not count against cfn-lint availability. Added MountError class to properly classify and exclude these from lint.error metrics.
When mounting fails for non-GitSync files, fall back to linting by content instead of failing the lint request. This improves resilience while still tracking mount failures separately.
Use telemetry.error with captureErrorAttributes for all error metrics to capture error type, location from stack trace, and other metadata while keeping user data secure. This provides better troubleshooting information for: - cfn-lint: init.fault, lint.error, mount.fault - pyodide: init faults (pyodide, pypi, wheels) - guard: validate.error, parser.error, wasm.error, memory errors, rules.load.error
kddejong
force-pushed
the
fix/telemetry-decorator-wiring
branch
from
February 13, 2026 20:07
14b9cf3 to
c3e0aeb
Compare
satyakigh
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve telemetry accuracy and troubleshooting capabilities
This PR improves telemetry metrics to better distinguish between service availability issues and infrastructure/developer
issues, while adding rich error attributes for troubleshooting.
Changes
Telemetry Decorator Wiring
Availability Metrics Accuracy
Mount Error Handling
Error Attributes for Troubleshooting
rules.load.error
Testing
Metrics Impact
This PR maintains backward compatibility for metric names but adds attributes that enable better filtering and analysis
in CloudWatch dashboards.