Skip to content

fix: bump undici, fast-xml-parser, and brace-expansion to resolve CVEs - #317

Merged
reyhankoyun merged 1 commit into
mainfrom
fix/dependabot-cves
Jul 31, 2026
Merged

fix: bump undici, fast-xml-parser, and brace-expansion to resolve CVEs#317
reyhankoyun merged 1 commit into
mainfrom
fix/dependabot-cves

Conversation

@reyhankoyun

@reyhankoyun reyhankoyun commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Resolves all open Dependabot security alerts by updating vulnerable transitive dependencies:

  • undici (High): WebSocket DoS via fragment count bypass, HTTP header injection, SameSite downgrade, response queue poisoning
  • fast-xml-parser (Moderate): XML Comment and CDATA injection via unescaped delimiters

Changes

  • Updated package-lock.json with patched versions
  • Rebuilt dist/ bundle to include patched runtime dependencies

Testing

  • npm audit reports 0 vulnerabilities
  • All 55 tests pass with 100% coverage

@reyhankoyun
reyhankoyun requested a review from a team as a code owner July 30, 2026 20:52
@reyhankoyun reyhankoyun added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code safe-to-test labels Jul 30, 2026
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (42007fc) to head (eab3c4f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #317   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          164       164           
  Branches        38        40    +2     
=========================================
  Hits           164       164           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@simonmarty

simonmarty commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

It looks like the brace-expansion is being brought by eslintrc and jest. Maybe we can wait for them to put out a patch release instead of doing an override? I feel like this override is something we're going to end up forgetting about in the future.

Plus they're dev-dependencies so that has me a little less worried than the other CVEs.

@reyhankoyun
reyhankoyun force-pushed the fix/dependabot-cves branch from a0c6169 to eab3c4f Compare July 30, 2026 21:53

@i-am-SR i-am-SR left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the PR description (changes) so it accurately reflects what shipped before merging?

@reyhankoyun
reyhankoyun merged commit 33da984 into main Jul 31, 2026
12 checks passed
@reyhankoyun
reyhankoyun deleted the fix/dependabot-cves branch July 31, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code safe-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants