Fix basis rotation and MPS orthogonality in METTS collapse - #4
Open
Rafael-DSoares wants to merge 3 commits into
Open
Fix basis rotation and MPS orthogonality in METTS collapse#4Rafael-DSoares wants to merge 3 commits into
Rafael-DSoares wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the X-basis measurements. The old code was accidentally flipping the X directions backwards, i.e., the state X+ basis was mapped onto the Z- and the X- to -Z+. So, I replaced the rotation gate with the Hadamard gate. This ensures that the X basis is mapped onto the Z basis in the correct way.
Changed sample to sample!. Before, the code would crash because the state had the incorrect orthogonality center before sampling. Adding the ! forces ITensors to automatically fix the orthogonality center right.
Updated read_last_product_state function to also return vectors of strings, which is useful when collapsing from a mixed basis. As a result, the product state arrays now correspond to vectors of strings with the specific basis direction.