prometheus-mssql-exporter with ServiceMonitor for K8S - #38
Open
sb185296 wants to merge 1 commit into
Open
Conversation
prometheus-mssql-exporter with ServiceMonitor for K8S
Owner
|
This looks very nice. But I am worried about the configuration environment at the end of the file as well as the 15s interval values. Do you think that this file should be more of a template (with extension .template) for instance. Can you also please update the readme.md file with details about k8s deploiment? |
|
Note that not everyone using prometheus operator so all provided |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prometheus-mssql-exporter with ServiceMonitor for K8S