Build with GHC9.8 and proto3-suite 0.9.3 - #170
Conversation
|
The CI jobs could probably run in parallel for different GHCs if we even want to keep building for multiple GHCs in CI |
| , containers >= 0.5 && < 0.7 | ||
| , managed >= 1.0.0 && < 1.1 | ||
| , template-haskell >= 2.16.0 && < 2.21 | ||
| , template-haskell >= 2.16.0 && < 2.22 |
| default-language: Haskell2010 | ||
| ghc-options: -Wall -Werror -fwarn-incomplete-patterns -fno-warn-unused-do-bind | ||
| if impl(ghc >= 9.8) | ||
| ghc-options: -Wno-x-partial |
There was a problem hiding this comment.
I believe you want impl(ghc >= 9.8) && impl(ghc < 9.8.3) (or maybe impl(ghc >= 9.8 && ghc < 9.8.3)? I'm not sure how you cabal's syntax has you write it, but the bug this flag is guarding against had it's fix merged to GHC 9.8.3).
There was a problem hiding this comment.
I can't find where the issue was fixed. Also we are running 9.8.4 https://github.com/awakesecurity/gRPC-haskell/actions/runs/15684778314/job/44185081098?pr=170#step:5:61
| default-language: Haskell2010 | ||
| ghc-options: -Wall -Werror -fwarn-incomplete-patterns -fno-warn-unused-do-bind -g -threaded -rtsopts | ||
| if impl(ghc >= 9.8) | ||
| ghc-options: -Wno-x-partial |
There was a problem hiding this comment.
This should be moved to a common stanza, and then imported into each top-level stanza since it's silencing a warning that certain versions of GHC are emitting, but shouldn't be.
|
[EDIT] waiting for @riz0id and @tm-drtina to tell me to merge. |
4 participants
No description provided.