sync code#53
Merged
Merged
Conversation
…#15348) The teardown cleanup added for #15183 only runs on a clean disconnect. If the service or its --server crashes before then, the headless logind session scope and the /tmp/.X<n> lock files it created leak the same way #15183 leaked them, with nothing to reclaim them afterwards. Record the session scope and display when the headless session starts, and on the next --server start reap exactly what the previous run recorded, then drop the marker. It only ever touches the one scope and display the previous run recorded, never a scan, so unrelated sessions are untouched; the reap and X cleanup reuse the teardown path. A logind session id is only unique within a boot: the counter lives in /run and resets, so a recorded "session-N.scope" can name a different, live session after a reboot. Tag the marker with the boot id and only reap the scope when it matches the current boot. A leaked cgroup cannot outlive a reboot, so nothing legitimate is lost cross-boot; the X lock cleanup stays pid-guarded and runs either way. Signed-off-by: TBX3D <88289044+TBX3D@users.noreply.github.com>
* fix(wayland): clipboard, support ext-data-control Signed-off-by: fufesou <linlong1266@gmail.com> * fix(clipboard): restart stale listener and log join panics Signed-off-by: fufesou <linlong1266@gmail.com> * update clipboard-master Signed-off-by: fufesou <linlong1266@gmail.com> * refactor(clipboard): remove redundant stale listener cleanup Signed-off-by: fufesou <linlong1266@gmail.com> --------- Signed-off-by: fufesou <linlong1266@gmail.com>
- dbus.rs: fix grammar (add 'between', pluralize 'processes') - win_impl.rs: fix typo 'hight' -> 'high', idiom 'such called' -> 'so-called' - startwm.sh: fix typo 'loging' -> 'logging' - lib.rs: fix copy-paste error in doc comments for scroll buttons - message.proto: fix typo 'Clipobard' -> 'Clipboard'
Bumps [libs/hbb_common](https://github.com/rustdesk/hbb_common) from `e50ac3c` to `387603f`. - [Release notes](https://github.com/rustdesk/hbb_common/releases) - [Commits](rustdesk/hbb_common@e50ac3c...387603f) --- updated-dependencies: - dependency-name: libs/hbb_common dependency-version: 387603f47cbb15c0d3dc3d67ae3396d3eb707daf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: fufesou <linlong1266@gmail.com>
Signed-off-by: fufesou <linlong1266@gmail.com>
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(fuse): fuse path broken, since ipc path changed Signed-off-by: fufesou <linlong1266@gmail.com> * fix(fuse): init, handle error Signed-off-by: fufesou <linlong1266@gmail.com> * fix(fuse): unmount attempt on newly created directory failed Signed-off-by: fufesou <linlong1266@gmail.com> --------- Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(clipboard): unix, refresh cached file size/mtime on re-copy sync_files() deduped re-copies by path string only, so editing a file and re-copying it (same path) skipped refreshing the cached size/mtime and the file-group descriptor; the peer then received the file truncated to the old cached size (silent corruption for PDF/zip/pptx). Widen the early-return guard to also compare a top-level (size, mtime) fingerprint and to always rebuild when a directory is selected. The Windows wf_cliprdr.c path re-stats per request and is unaffected. Signed-off-by: RAIT-09 <51452399+RAIT-09@users.noreply.github.com> * opt(clipboard): unix, compute file fingerprint once and pass into sync_files fingerprint() was computed before taking the CLIP_FILES lock and then recomputed inside ClipFiles::sync_files under the lock. Pass the precomputed value in so the top-level stat runs once and outside the critical section. No behavior change. Signed-off-by: RAIT-09 <51452399+RAIT-09@users.noreply.github.com> --------- Signed-off-by: RAIT-09 <51452399+RAIT-09@users.noreply.github.com>
Incorrect translation
* Support controller user attribution in audit logs
This PR supports associating audit logs with the controller user.
## Implementation:
- Add `ControlledContext { conn_audit_token }` to `PunchHole`, `RequestRelay`, and `FetchLocalAddr`.
- The server sends a controller-user identity snapshot to the controlled client through rendezvous messages.
- The controlled client sends the token back to the server when posting the `on_open` conn audit or IP whitelist alarm audit.
- This lets the server attach the controller user to audit logs.
## How the controlled client helps identify the controller user:
- Conn audit: sends the token to the server in `on_open`; the server creates the audit log and caches the user snapshot.
- File audit: sends `id` and `conn_id`; the server uses them to find the cached user snapshot.
- Alarm audit: IP whitelist sends the token directly; other alarm logs send `id` and `conn_id`, and the server uses them to find the cached user
snapshot.
## Compatibility:
- Supported only for logs created with a new server and a new controlled client.
- Does not require upgrading the controller client.
## Test
- [x] New/old clients connected to new/old servers, and conn/file/alarm audit logs worked normally.
- [x] New client connected to new server generated searchable conn/file/alarm audit logs.
- [x] Punch hole, local addr, and relay paths worked with audit logs and control role on new/old servers.
- [x] Direct IP connections produced audit logs, but do not support user audit.
Signed-off-by: 21pages <sunboeasy@gmail.com>
* rename conn_audit_token to conn_audit_ref
Signed-off-by: 21pages <sunboeasy@gmail.com>
---------
Signed-off-by: 21pages <sunboeasy@gmail.com>
* fix(clipboard): clean up stale Linux FUSE mounts Recover Linux file clipboard FUSE mount points before remounting and stop treating a cached context as valid when the mount has already gone away. This fixes the desktop file manager copy failure that shows dialogs such as "Error while copying a" and "There was an error copying the file into xxx". Signed-off-by: fufesou <linlong1266@gmail.com> * fix(clipboard): fuse, reduce dups Signed-off-by: fufesou <linlong1266@gmail.com> * fix: clear Linux file clipboard before unmounting FUSE Ensure Linux client teardown clears RustDesk file clipboard URLs while the FUSE context is still available. Also prefer fusermount before umount to avoid noisy unprivileged teardown attempts. Signed-off-by: fufesou <linlong1266@gmail.com> * fix(clipboard): return and log errors Signed-off-by: fufesou <linlong1266@gmail.com> --------- Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(update): msi, norestart Signed-off-by: fufesou <linlong1266@gmail.com> * fix(update): escape path Signed-off-by: fufesou <linlong1266@gmail.com> --------- Signed-off-by: fufesou <linlong1266@gmail.com>
Update translation for outdated installation message
Signed-off-by: liuqiang <2465199797@qq.com>
* Add authentication details to connection audit Signed-off-by: 21pages <sunboeasy@gmail.com> * rename normalize_conn_audit_primary_auth to normalize_conn_audit_auth_fields Signed-off-by: 21pages <sunboeasy@gmail.com> * Merge permanent password audit methods Signed-off-by: 21pages <sunboeasy@gmail.com> * Simplify connection audit auth methods Signed-off-by: 21pages <sunboeasy@gmail.com> --------- Signed-off-by: 21pages <sunboeasy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.