Pre release cleanup - #68
Merged
Merged
Conversation
Replaces the inline lambda in NumericSequence.euler() with a named rule function to make the sequence definition clearer.
Extends CI and local verification to cover tests and examples, and fix the resulting typing and style issues.
Separates type-preserving reconstruction from reindexing behavior, allowing sequence types to control how derived sequences preserve their semantics, while enabling better support for static type checking. Replaces a previous unification of distinct execution paths by splitting the reconstruction protocol into separate factories, resolving the tension between type-preserving reconstructions (e.g. resize) and subclass-specific semantics (e.g. reindex).
Replaces pyflakes, pycodestyle, and pydocstyle with Ruff for static analysis, code style checking, and docstring style checking. Updates CI, development tooling, and source formatting accordingly.
Removes unused sequence transformations that add maintenance burden in subclasses without providing a concrete use case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agreed on all four. Revised paragraphs:
Improves the readability of the Euler sequence definition.
Improves naming within subsequence construction for clarity.
Extends static verification, previously limited to the library itself, to cover
the test suite and examples, and fixes the typing and style issues this
surfaces.
Splits sequence reconstruction into separate factory methods for resizing and
reindexing, replacing an earlier unified approach that conflated
type-preserving reconstruction with subclass-specific reindexing semantics, and
improves static type checking as a result.
Replaces pyflakes, pycodestyle, and pydocstyle with Ruff across static
analysis, style, and docstring checking, updating CI, development tooling, and
source formatting accordingly.
Adds pip caching to the CI workflow's setup-python steps to speed up dependency
installation.
Adds trailing commas to function calls wrapped across multiple lines, aligning
them with the project's line-wrapping conventions.
Revises the development guide's local verification, feature implementation, and
record-keeping guidance.
Removes TODO items that were already resolved or no longer relevant.
Revises the README's vision, subclass list, project layout, verification
instructions, and documentation summary to reflect the current state of the
project.
Adds conventions for pull request descriptions to the style guide.
Changes validate_int's default to accept boolean values as integers.
Removes shift_by() and shift_to(), unused sequence transformations that added
maintenance burden without a concrete use case.
Resets the design notes document, moving its accumulated history to a separate
legacy file, and adopts a more conservative, dated, append-only convention for
future entries.
Handles slicing an infinite sequence with a negative step and no explicit start
by returning an empty result instead of raising an internal assertion error.
Brightens the header image used in the README.
Fills gaps in class docstrings.
Adds missing members to the architecture diagram.
Adds planned features to the TODO list.