fix: harden remove flows and machine-readable error semantics - #9
Merged
Merged
Conversation
Ignore canonical self-path when checking remaining agent skill references so remove can clean orphan canonical directories. Add mock /api/v1/skills support and a CLI-only lifecycle e2e flow (find/info/add/remove/list), and make install-then-remove test non-interactive with JSON mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
askill removebehavior across name/path targets: resolve scope correctly, clean orphan canonical directories, and provide a clear--global (-g)hint when a skill is only installed globally.ok: false, structuredfailedentries, and non-zero exit codes so automation can reliably detect errors.collection,parser,remove-target) and stronger E2E lifecycle/remove-json scenarios.Validation
npm testnpm run test:e2e