Conversation
JuliaLang/julia#62221 changes JuliaLowering’s expansion API, syntax contexts, and inert syntax representation. Without matching updates, JETLS can lose source-aware bindings, mis-handle generated code, and resolve macro-generated names in the caller’s scope. Rebase source trees before expansion, derive binding layers from `SyntaxContext`, and handle `syntaxinert` throughout binding and occurrence analysis. Update the new-style Base macro stubs to preserve provenance while keeping generated locals hygienic and using explicit `Base`/`Core` references for fixed helpers. Evaluate nested `@static` conditions in the caller module and teach noreturn detection about explicit global references so definite-assignment analysis remains accurate. Co-Authored-By: GPT-5.6 Sol <noreply@openai.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #799 +/- ##
==========================================
+ Coverage 78.35% 78.40% +0.05%
==========================================
Files 62 62
Lines 13160 13246 +86
==========================================
+ Hits 10311 10386 +75
- Misses 2849 2860 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JuliaLang/julia#62221 changes JuliaLowering’s expansion API, syntax contexts, and inert syntax representation. Without matching updates, JETLS can lose source-aware bindings, mis-handle generated code, and resolve macro-generated names in the caller’s scope.
Rebase source trees before expansion, derive binding layers from
SyntaxContext, and handlesyntaxinertthroughout binding and occurrence analysis. Update the new-style Base macro stubs to preserve provenance while keeping generated locals hygienic and using explicitBase/Corereferences for fixed helpers.Evaluate nested
@staticconditions in the caller module and teach noreturn detection about explicit global references so definite-assignment analysis remains accurate.constdeclaration on local variable report on every file on exact same line #554:scope_layerinterfering with user code JuliaLang/JuliaLowering.jl#108