Skip to content

diagnostic: Label inference related frames#793

Merged
aviatesk merged 1 commit into
masterfrom
diagnostic-label-related-frames
Jul 1, 2026
Merged

diagnostic: Label inference related frames#793
aviatesk merged 1 commit into
masterfrom
diagnostic-label-related-frames

Conversation

@aviatesk

@aviatesk aviatesk commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Inference diagnostics with related information previously showed only the related frame signature. For attributed reports, this made it hard to tell which frame was the error origin, which frames were intermediate calls, and which frame was the analysis entry that reported the diagnostic.

Carry a RelatedFrameKind alongside each related virtual-stack frame and prefix related-information messages with origin:, via:, or entry: when converting inference reports to LSP diagnostics. This keeps the existing frame signature while making the role of each related frame explicit.

The change is covered by analyzer and diagnostic integration tests, and the Unreleased changelog documents the updated related-information format with an example.

Inference diagnostics with related information previously showed only
the related frame signature. For attributed reports, this made it hard
to tell which frame was the error origin, which frames were intermediate
calls, and which frame was the analysis entry that reported the
diagnostic.

Carry a `RelatedFrameKind` alongside each related virtual-stack frame
and prefix related-information messages with `origin:`, `via:`, or
`entry:` when converting inference reports to LSP diagnostics. This
keeps the existing frame signature while making the role of each related
frame explicit.

The change is covered by analyzer and diagnostic integration tests, and
the Unreleased changelog documents the updated related-information
format with an example.

Co-Authored-By: GPT-5.5 <noreply@openai.com>
@aviatesk
aviatesk force-pushed the diagnostic-label-related-frames branch from 2162886 to f2c66c9 Compare July 1, 2026 03:34
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.33%. Comparing base (68c5058) to head (f2c66c9).

Files with missing lines Patch % Lines
src/diagnostic.jl 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
+ Coverage   78.29%   78.33%   +0.03%     
==========================================
  Files          62       62              
  Lines       12881    12890       +9     
==========================================
+ Hits        10085    10097      +12     
+ Misses       2796     2793       -3     
Flag Coverage Δ
JETLS.jl 78.33% <95.23%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aviatesk
aviatesk merged commit 5df4308 into master Jul 1, 2026
18 of 19 checks passed
@aviatesk
aviatesk deleted the diagnostic-label-related-frames branch July 1, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant