fix(ci): sync package-lock.json with the Originals 2.x bump - #214
Merged
Conversation
Every `npm ci` job (Deploy Convex, Mobile Build CI) fails on main: npm error Invalid: lock file's @originals/sdk@1.8.3 does not satisfy @originals/sdk@2.1.0 33aa6de bumped package.json and bun.lock to 2.0.0 but left package-lock.json on the 1.8.x line, and #213's bump to 2.1.0 inherited the drift. It only surfaced once #213 merged, because the workflows that use npm run on push to main. Regenerated with `npm install --package-lock-only` (node_modules untouched — local/Railway installs still come from bun.lock). `npm ci --dry-run` now passes. The repo carries both lockfiles: Railway installs with bun, CI with npm ci, so a dependency change has to touch both or CI breaks the next time it runs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
e2e.yml has never run a real test. There is no Playwright in this repo — not a dependency, no config file, no test directory, no @playwright/test imports. So `bunx playwright test` starts with no config, falls back to globbing the repo with its default **/*.test.* pattern, picks up the bun/node unit tests, and dies on their `bun:test` imports: Error: Only URLs with a scheme in: file, data, and node are supported by the default ESM loader. Received protocol 'bun:' It has failed identically on every commit going back past 3f7b003. Meanwhile `bun test` — 101 real tests — ran nowhere in CI. Replaced with test.yml, which installs with --frozen-lockfile (so a package.json change that skips bun.lock fails here rather than at deploy, mirroring the npm ci check) and runs the suite. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
npm cijob is failing onmainright now — includingDeploy Convex, so the backend from #213 never deployed.Cause
33aa6de bumped
package.json+bun.lockto 2.0.0 but leftpackage-lock.jsonon the 1.8.x line. #213's bump to 2.1.0 inherited that drift. It stayed invisible on the branch because the PR checks that usenpm ciwere already red for the same reason — it only became load-bearing once #213 merged andDeploy Convexran on push to main.The repo carries two lockfiles with different consumers:
RAILPACK,packageManager: bun@1.3.5)bun.lockpackage-lock.jsonvianpm cibun installSo a dependency change has to touch both, or CI breaks the next time it runs.
Fix
Regenerated with
npm install --package-lock-only—node_modulesuntouched, so local and Railway installs still resolve frombun.lock.npm ci --dry-runnow passes.Verified on this branch:
bun test101 pass / 0 fail,vite buildclean.Not fixed here
E2E Tests is also red, but it's unrelated and pre-existing — it installs with
bun, notnpm ci. The failure (Only URLs with a scheme in: file, data, and node are supported by the default ESM loader. Received protocol 'bun:') appears identically on 3f7b003, before any of this work. Left alone rather than folded into a CI-unblock PR.After merge
Deploy Convexshould go green and push the schema + functions. The migration still has to be run by hand:🤖 Generated with Claude Code
Note
Replace E2E CI workflow with a Bun unit test workflow
--frozen-lockfileon push/PR to main.package-lock.jsonto sync with the Originals 2.x dependency bump.Macroscope summarized 63619ce.