Skip to content

fix(2479): send the latest feedback id in staff feedback list items - #483

Merged
syphax-FN merged 1 commit into
developfrom
fix/2479-staff-feedback-latest-id
Sep 3, 2026
Merged

fix(2479): send the latest feedback id in staff feedback list items#483
syphax-FN merged 1 commit into
developfrom
fix/2479-staff-feedback-latest-id

Conversation

@syphax-FN

@syphax-FN syphax-FN commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Brief description of changes applied

The backend now returns latestFeedbackId (the id of the student's most recent feedback for the activity) alongside id in FeedbackStaffListItemDTO. The "All feedback requests" list now navigates to the detail page using this new id instead of the clicked feedback's own id, which could be an older iteration not present in feedbacksByActivity, leaving the student selector empty on the detail page.

Reference to an Issue, Feature, Task, User Story or another PR

Related to #2479

Target Branch

develop

Additional Notes

Fix approach suggested by @pascal-beger in Mattermost discussion — the backend should send the correct id from the start instead of compensating on the frontend.

Known Limitations or Side Effects

FeedbackHistoryCard, FeedbackLongIconCard and notifications are not touched (out of scope for this fix).


✅ Checklist

  • a11y tested (if the PR includes frontend changes)
  • Tests provided (including unit and integration tests for both frontend and backend)
  • i18n handled (texts are translated)
  • Performance tests
  • No unnecessary code (e.g., debug logs, commented code)
  • Code style and formatting rules respected (linting, conventions, etc.)
  • Semantic Versioning respected
  • Add to CHANGELOG.md file all properties and database change and details for the update process

@syphax-FN
syphax-FN force-pushed the fix/2479-staff-feedback-latest-id branch from 8202168 to f212594 Compare September 3, 2026 13:31

@p-beger p-beger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça me semble bon, merci Syphax !

@syphax-FN
syphax-FN merged commit f212594 into develop Sep 3, 2026
6 checks passed
@syphax-FN
syphax-FN deleted the fix/2479-staff-feedback-latest-id branch September 3, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants