fix(2479): send the latest feedback id in staff feedback list items - #483
Merged
Conversation
syphax-FN
force-pushed
the
fix/2479-staff-feedback-latest-id
branch
from
September 3, 2026 13:31
8202168 to
f212594
Compare
p-beger
approved these changes
Sep 3, 2026
p-beger
left a comment
Contributor
There was a problem hiding this comment.
Ça me semble bon, merci Syphax !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of changes applied
The backend now returns
latestFeedbackId(the id of the student's most recent feedback for the activity) alongsideidinFeedbackStaffListItemDTO. The "All feedback requests" list now navigates to the detail page using this new id instead of the clicked feedback's own id, which could be an older iteration not present infeedbacksByActivity, leaving the student selector empty on the detail page.Reference to an Issue, Feature, Task, User Story or another PR
Related to #2479
Target Branch
developAdditional Notes
Fix approach suggested by @pascal-beger in Mattermost discussion — the backend should send the correct id from the start instead of compensating on the frontend.
Known Limitations or Side Effects
FeedbackHistoryCard,FeedbackLongIconCardand notifications are not touched (out of scope for this fix).✅ Checklist
CHANGELOG.mdfile all properties and database change and details for the update process