feat(2417): add AvSkipLinks - #344
Merged
Merged
Conversation
elrhourha
reviewed
Aug 25, 2026
| }, | ||
| }, | ||
| template: ` | ||
| <nav aria-label="Accès rapide" data-testid="av-skip-links"> |
Contributor
There was a problem hiding this comment.
Suggested change
| <nav aria-label="Accès rapide" data-testid="av-skip-links"> | |
| <nav aria-label="Accès rapide" data-testid="skip-links"> |
Collaborator
Author
There was a problem hiding this comment.
C'est si important que ça ? 😅
| <nav | ||
| v-if="skipLinks.length > 0" | ||
| class="av-col av-skip-links" | ||
| data-testid="skip-links" |
Contributor
There was a problem hiding this comment.
ariaLabel et role manquant je pense
Collaborator
Author
There was a problem hiding this comment.
@elrhourha on s'était dit que c'était à la personne qui instancie le composant de penser à mettre le aria pour ne pas avoir cette prop superflue. Ce n'est plus d'actualité ?
Concernant le role, on est déjà sur un <nav, le role navigation est vraiment utile ? C'est pas redondant ?
elrhourha
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Description
Brief description of changes applied
✨ add AvSkipLinks
Reference to an Issue, Feature, Task, User Story or another PR
Linked to avenirs-esr/AVENIRS-Project#2417
Documentation
Target Branch
develop
Additional Notes
Capture.video.du.2026-08-25.12-57-29.mp4
Known Limitations or Side Effects
✅ Checklist
Please make sure you have addressed the following before submitting:
CHANGELOG.mdfile all properties and database change and detaiils for the update process