Skip to content

docs: mark RuntimeConfig::chunk_emb_workers as currently unused #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
attevon-admin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

docs: mark RuntimeConfig::chunk_emb_workers as currently unused #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
057b21b
docs: mark chunk_emb_workers as currently unused
davidamacey Aug 25, 2026
afae222
docs: clarify chunk_emb_workers is a CoreML-only concept, not CUDA
davidamacey Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/pipeline/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,16 @@ impl PipelineConfig {
/// Controls execution parameters that do not affect correctness but do affect performance.
#[derive(Debug, Clone)]
pub struct RuntimeConfig {
/// Number of chunk embedding workers
/// Number of chunk embedding workers.
///
/// Currently unused: no code path reads this field on either the CUDA or CoreML
/// execution mode (verified against the whole crate — see #13). Its sibling field
/// below, `chunk_emb_compute_units`, is CoreML-only, and CoreML sessions can only
/// run one at a time — so this almost certainly exists to parallelize chunk
/// embedding across several single-threaded CoreML workers rather than to control
/// CUDA concurrency (CUDA already gets concurrency from shared, mutex-protected
/// ORT sessions). It's reserved for that future CoreML worker-pool implementation;
/// setting it has no effect today on any mode.
pub chunk_emb_workers: usize,
/// CoreML compute units for chunk embedding (CoreML modes only)
#[cfg(feature = "coreml")]
Expand Down