Fix Root element is missing exception#15
Merged
Conversation
Collaborator
|
Hi @jayfunc , sorry for the late reply. I finally had some time to take a closer look. The cause of this problem is 7f89630. Last.fm/src/Hqub.Lastfm/Request.cs Lines 130 to 140 in 7f89630 In the Thanks for bringing this to my attention! |
Contributor
Author
|
Hi, I have done the modification. Thank you for your response! |
Collaborator
|
Thank you! I will do a patch release in the next days. |
Collaborator
|
@jayfunc I have updated the nuget package. |
Contributor
Author
|
@wo80 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for your work, but I came across the error when I used this package in my WinUI 3 project with .NET 8.
I tried to get the auth URL, and it gave me an error: "Root element is missing". After forking it and locating it, the error seems like something is wrong with the
Stream.I added a few lines based on the comment below:
https://stackoverflow.com/questions/10125810/root-element-is-missing
And the error no longer exists. I also tested some other functions like getting user info and posting scrobbling, and they worked well.
I just created this pull request to make this package more stable and with fewer bugs.
Hope this helped!