chore: Rename to avoid lint hits

[alarso16]

Why this should be merged

Removes files named ...test....go, when it's not a test file. The linter is over-reaching, but this blocks repo-merger

How this works

Only one constant in each file, with corresponding non-test files that it could use instead.

How this was tested

Lint

Need to be documented?

No

Need to update RELEASES.md?

No

[JonathanOppenheimer]

I don't think this will work. The rule test_import_testing_only_in_tests ensures that testing-related packages are only imported in actual test files or designated test packages. Both the files you changed the name of still import testing. I also think the file names are correct, because they are test files, and there's no need to rename them.

[alarso16]

They are used in production code, and therefore not test files. They do not import testing, their generated code imports testing

[JonathanOppenheimer]

They are used in production code, and therefore not test files. They do not import testing, their generated code imports testing

I don't think this matters- the grep doesn't distinguish between actual imports and strings - it just looks for the pattern in the file content. So even though line 15 is inside a backtick string template, the grep would still find it and report an error. (as it did in my PR chain which discovered this after I removed the skiplint rules.)

[alarso16]

There's actually a bug in the linter code, it's not a problem though. You can just keep it in the other PR

[JonathanOppenheimer]

There's actually a bug in the linter code, it's not a problem though. You can just keep it in the other PR

A bug in the AvalancheGo linter or the EVM linters? Happy to try to fix!