feat(agnocast): adopt CallbackIsolatedAgnocastExecutor (CIE) (#72) - #98
Merged
Conversation
mitsudome-r
approved these changes
Sep 4, 2026
xmfcx
force-pushed
the
feat/jazzy-08-agnocast-cie
branch
from
September 4, 2026 09:48
f6cafed to
11904ee
Compare
xmfcx
force-pushed
the
feat/jazzy-08-agnocast-cie
branch
from
September 4, 2026 10:07
11904ee to
5866b20
Compare
* feat: adopt cie Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * fix Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * fix Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * fix: dependency Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * revert: launch fix Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * feat: dependency condition Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * feat: thread name includes interface name Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * feat: update condition style Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * fix Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> --------- Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> (cherry picked from commit e16bb19) Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
xmfcx
force-pushed
the
feat/jazzy-08-agnocast-cie
branch
from
September 4, 2026 10:48
5866b20 to
51c89f2
Compare
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport optional Agnocast support from
maintojazzy. This is layer 8 of 11, and it now targetsjazzybecause the first seven layers merged.agnocast): adoptCallbackIsolatedAgnocastExecutor(CIE) #72With
ENABLE_AGNOCAST=1, both components useCallbackIsolatedAgnocastExecutor, and the receiver creates its thread through the Agnocast configurator. A follow-up adds two indentation spaces that Humble requires and Jazzy accepts.The cherry-pick preserves the original author and omits the original AI co-author trailer.
The CI follow-up awaits a separate review.
AI usage
AI usage: Cherry-picked from
mainwith Claude Code. Codex prepared the CI follow-up, propagated it through normal merge commits, and ran the local checks below.Self-review: Pure backport, I checked the order and verified that it is correct.
Verification: Local package builds and tests passed on Humble and Jazzy.
CI on the published head
uncrustifyrequested two more spaces on the thread argument line.Summary: 210 tests, 0 errors, 2 failures, 50 skipped.First local test invocation
0.1before any tests ran because the command omitted the isolated install path.--install-baseto the test command.Humble and Jazzy package builds and tests
Tested
a98566162202c0b4fb6bc4996300a2d4a3ec2a26in Ubuntu 22.04 / Humble and Ubuntu 24.04 / Jazzy containers. All colcon commands ran from/home/mfc/projects/autoware, with isolated build and install paths, Release mode, and--coverage.0.Summary: 210 tests, 0 errors, 0 failures, 50 skippedSummary: 216 tests, 0 errors, 0 failures, 52 skipped