fix(packaging): drop bogus tool/ruff runtime deps, declare build-system#20
Merged
Conversation
`tool>=0.8.0` and `ruff>=0.14.0` were listed as runtime dependencies but are not imported anywhere in the SDK. `ruff` is a linter (dev-only at most) and `tool` is unrelated 2011 abandonware (GPL3, argh/pydispatcher/pyyaml, sdist-only with no wheels). Dragging them in forces extra source builds at install time, which breaks the DataMaker desktop runner's *offline* venv build on Windows (`uv sync --offline --no-index`) — scenarios then never run because the runner venv is never created. macOS installs online and tolerated it. - Remove `tool` and `ruff` from runtime dependencies (neither is imported). - Add an explicit setuptools `[build-system]` + `[tool.setuptools.packages.find]` (where = src) so the wheel build no longer relies on the build frontend's implicit backend / src-layout autodiscovery. Verified `uv build --wheel` produces a clean wheel whose only Requires-Dist are python-dotenv and requests, with the `datamaker` package correctly included. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TMwtcrQZ2WSMZB7wZYM6za
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tool>=0.8.0andruff>=0.14.0are declared as runtime dependencies but are not imported anywhere in the SDK:ruffis a linter (dev-only at most).toolis unrelated 2011 abandonware (GPL3; pullsargh/pydispatcher/pyyaml; sdist-only, no wheels).The DataMaker desktop app builds its Python runner venv offline on Windows (
uv sync --frozen --offline --no-index --find-links wheelhouse). These extra source-only deps must be built on the user's machine with no network. That build fails / the wheelhouse can't satisfy it,uv syncaborts, the runner venv is never created, and scenarios silently never run on Windows. macOS installs online and tolerated it.Fix
toolandrufffrom runtimedependencies(neither is imported).[build-system]and[tool.setuptools.packages.find] where = ["src"]so the wheel build no longer depends on the frontend's implicit backend / src-layout autodiscovery.Verification
uv build --wheelproduces a clean wheel:Requires-Dist: onlypython-dotenv>=1.0.1andrequests>=2.32.3datamaker/package correctly included (datamaker/__init__.py,main.py,routes/*)🤖 Generated with Claude Code