Skip to content

chore: fix broken test#3233

Merged
tstirrat15 merged 1 commit into
mainfrom
tstirrat/fix-broken-hashcache-test
Jul 13, 2026
Merged

chore: fix broken test#3233
tstirrat15 merged 1 commit into
mainfrom
tstirrat/fix-broken-hashcache-test

Conversation

@tstirrat15

@tstirrat15 tstirrat15 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Description

This test was failing reliably prior to this.

Changes

  • Use an atomic for loadCalls
  • Use an errgroup for the spawned goroutines
  • Use Go() instead of Add()

Testing

Review. See that tests pass.

@github-actions github-actions Bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Jul 13, 2026
@tstirrat15 tstirrat15 force-pushed the tstirrat/fix-broken-hashcache-test branch from 55338ce to 668b7f3 Compare July 13, 2026 22:06
@tstirrat15 tstirrat15 force-pushed the tstirrat/fix-broken-hashcache-test branch from 668b7f3 to d9bf264 Compare July 13, 2026 22:18
@tstirrat15 tstirrat15 marked this pull request as ready for review July 13, 2026 22:20
@tstirrat15 tstirrat15 requested a review from a team as a code owner July 13, 2026 22:20
@tstirrat15 tstirrat15 enabled auto-merge (squash) July 13, 2026 22:30
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@josephschorr josephschorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tstirrat15 tstirrat15 merged commit 70ece3d into main Jul 13, 2026
46 checks passed
@tstirrat15 tstirrat15 deleted the tstirrat/fix-broken-hashcache-test branch July 13, 2026 22:56
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) Skip-Changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants