chore: add test for ttl behavior#3218
Open
tstirrat15 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
area/datastore
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 7230fde | Previous: cbdf06c | Ratio |
|---|---|---|---|
BenchmarkDatastoreDriver/cockroachdb-overlap-static/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) |
34958513 ns/op 175021 B/op 20202 allocs/op |
6805173 ns/op 172708 B/op 20195 allocs/op |
5.14 |
BenchmarkDatastoreDriver/cockroachdb-overlap-static/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op |
34958513 ns/op |
6805173 ns/op |
5.14 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) |
35002488 ns/op 173914 B/op 20199 allocs/op |
6853237 ns/op 172793 B/op 20195 allocs/op |
5.11 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op |
35002488 ns/op |
6853237 ns/op |
5.11 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Touch (github.com/authzed/spicedb/internal/datastore/benchmark) |
6259214 ns/op 22187 B/op 287 allocs/op |
2857511 ns/op 22094 B/op 287 allocs/op |
2.19 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Touch (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op |
6259214 ns/op |
2857511 ns/op |
2.19 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Create (github.com/authzed/spicedb/internal/datastore/benchmark) |
6289606 ns/op 19549 B/op 281 allocs/op |
2004369 ns/op 19414 B/op 281 allocs/op |
3.14 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Create (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op |
6289606 ns/op |
2004369 ns/op |
3.14 |
This comment was automatically generated by workflow using github-action-benchmark.
miparnisari
approved these changes
Jul 8, 2026
miparnisari
approved these changes
Jul 10, 2026
miparnisari
force-pushed
the
tstirrat/add-cache-ttl-test
branch
from
7230fde to
fa34281
Compare
tstirrat15
force-pushed
the
tstirrat/add-cache-ttl-test
branch
from
fa34281 to
bb5e67e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We had questions about whether TTL behavior was working as expected in the new caching library so I wrote a test.
Changes
Wait()from interface, since the implementation that required it (ristretto) no longer exists.Testing
Review.