Skip to content

test: fix flaky TestConsistencyPerDatastore/postgres#3216

Merged
miparnisari merged 1 commit into
mainfrom
test-fix-flake-index-checking-proxy
Jul 7, 2026
Merged

test: fix flaky TestConsistencyPerDatastore/postgres#3216
miparnisari merged 1 commit into
mainfrom
test-fix-flake-index-checking-proxy

Conversation

@miparnisari

Copy link
Copy Markdown
Contributor

Fixes

--- FAIL: TestConsistencyPerDatastore (426.10s)
    --- FAIL: TestConsistencyPerDatastore/postgres (426.10s)
        --- FAIL: TestConsistencyPerDatastore/postgres/teamwitharrow.yaml (25.86s)
            --- FAIL: TestConsistencyPerDatastore/postgres/teamwitharrow.yaml/chunk-size-5 (0.09s)
                --- FAIL: TestConsistencyPerDatastore/postgres/teamwitharrow.yaml/chunk-size-5/caching (20.91s)
                    --- FAIL: TestConsistencyPerDatastore/postgres/teamwitharrow.yaml/chunk-size-5/caching/validate_lookup_resources_test/repository_read_ (0.59s)
                        --- FAIL: TestConsistencyPerDatastore/postgres/teamwitharrow.yaml/chunk-size-5/caching/validate_lookup_resources_test/repository_read_/test/user:ivan (0.15s)
                            --- FAIL: TestConsistencyPerDatastore/postgres/teamwitharrow.yaml/chunk-size-5/caching/validate_lookup_resources_test/repository_read_/test/user:ivan/pagesize-2 (0.08s)
                                suite.go:263: 
                                    	Error Trace:	/home/runner/work/spicedb/spicedb/internal/services/integrationtesting/consistencytestutil/suite.go:263
                                    	Error:      	Received unexpected error:
                                    	            	rpc error: code = Unknown desc = unable to query relationships: received empty explain
                                    	Test:       	TestConsistencyPerDatastore/postgres/teamwitharrow.yaml/chunk-size-5/caching/validate_lookup_resources_test/repository_read_/test/user:ivan/pagesize-2
FAIL
coverage: 24.7% of statements in ./...

@miparnisari miparnisari requested a review from a team as a code owner July 6, 2026 19:49
@github-actions github-actions Bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Jul 6, 2026
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: db14f92 Previous: eb71906 Ratio
BenchmarkDatastoreDriver/cockroachdb-overlap-static/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) 34144007 ns/op 173657 B/op 20197 allocs/op 7626381 ns/op 172725 B/op 20195 allocs/op 4.48
BenchmarkDatastoreDriver/cockroachdb-overlap-static/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op 34144007 ns/op 7626381 ns/op 4.48
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) 33696462 ns/op 173648 B/op 20198 allocs/op 7887499 ns/op 172742 B/op 20195 allocs/op 4.27
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op 33696462 ns/op 7887499 ns/op 4.27
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Touch (github.com/authzed/spicedb/internal/datastore/benchmark) 6348529 ns/op 22391 B/op 287 allocs/op 2923135 ns/op 22033 B/op 287 allocs/op 2.17
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Touch (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op 6348529 ns/op 2923135 ns/op 2.17
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Create (github.com/authzed/spicedb/internal/datastore/benchmark) 6137641 ns/op 19583 B/op 281 allocs/op 2704564 ns/op 19463 B/op 281 allocs/op 2.27
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Create (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op 6137641 ns/op 2704564 ns/op 2.27

This comment was automatically generated by workflow using github-action-benchmark.

explainBuilder.WriteString(explain + "\n")
}

if err := rows.Err(); err != nil {

@miparnisari miparnisari Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as line 211

@tstirrat15 tstirrat15 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miparnisari miparnisari enabled auto-merge (squash) July 7, 2026 20:59
@miparnisari miparnisari force-pushed the test-fix-flake-index-checking-proxy branch from d0162b2 to db14f92 Compare July 7, 2026 20:59
@miparnisari miparnisari merged commit cbdf06c into main Jul 7, 2026
74 of 77 checks passed
@miparnisari miparnisari deleted the test-fix-flake-index-checking-proxy branch July 7, 2026 23:29
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) Skip-Changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants