Played Dles can reset on their own timezone - #67
Open
yonasadiel wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this proposal, I change the behaviour of "reset played dles at midnight" proposed at #13 . The problem is, different dles have their own reset time: some are reset on their own specific timezone, some reset based on the client's timezone. So I propose a change:
I can help to check the reset time of the dles as many as I can, but I want to get opinions before committing more time on this idea.
Additionally, I also have an idea to show some timer / small alert if some of the favourited dles is approaching the deadline but not marked yet, so it will help to keep daily streak? But this might be too much UI disruption for not much benefit, considering most of dles doesn't have concept of daily streak anyway.