Skip to content

Played Dles can reset on their own timezone - #67

Open
yonasadiel wants to merge 3 commits into
aukspot:mainfrom
yonasadiel:reset-timezone
Open

Played Dles can reset on their own timezone#67
yonasadiel wants to merge 3 commits into
aukspot:mainfrom
yonasadiel:reset-timezone

Conversation

@yonasadiel

Copy link
Copy Markdown

In this proposal, I change the behaviour of "reset played dles at midnight" proposed at #13 . The problem is, different dles have their own reset time: some are reset on their own specific timezone, some reset based on the client's timezone. So I propose a change:

  • Every dles will have "resetTime" to indicate whether the dles should reset on what timezone. By default, the value is "client", which means it will follow the client device's timezone. This is backward compatible, following the current behaviour.
  • Instead of storing the date of the last reset, we store the time too (in ISO format). This way, we can reset each dles individually.
  • Add some of known reset time.

I can help to check the reset time of the dles as many as I can, but I want to get opinions before committing more time on this idea.

Additionally, I also have an idea to show some timer / small alert if some of the favourited dles is approaching the deadline but not marked yet, so it will help to keep daily streak? But this might be too much UI disruption for not much benefit, considering most of dles doesn't have concept of daily streak anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant