Skip to content

Add MQTT location response tests#8

Merged
augard merged 2 commits into
mainfrom
codex/test-gap-mqtt-location-response
Mar 4, 2026
Merged

Add MQTT location response tests#8
augard merged 2 commits into
mainfrom
codex/test-gap-mqtt-location-response

Conversation

@augard

@augard augard commented Mar 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • add VehicleMQTTLocationResponseTests to cover merged timestamp decoding
  • verify valid timestamp parsing yields expected UTC components even when location is null
  • ensure invalid timestamp formats throw and round-trip formatter via MergedDateFormatter

Testing

  • Not run (not requested)

Copilot AI review requested due to automatic review settings March 3, 2026 07:28
@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

There is a problem with the Gemini CLI PR review. Please check the action logs for details.

@augmentcode

augmentcode Bot commented Mar 3, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Adds test coverage for MQTT location responses and merged timestamp decoding.

Changes:

  • Add VehicleMQTTLocationResponseTests to exercise latestUpdateTime parsing (yyyyMMddHHmmss) and Location: null decoding.
  • Assert the parsed Date matches expected UTC components.
  • Ensure invalid timestamp formats throw and validate MergedDateFormatter round-trip behavior.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread KiaTests/VehicleMQTTLocationResponseTests.swift Outdated
Comment thread KiaTests/VehicleMQTTLocationResponseTests.swift Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new XCTest suite to validate decoding of MQTT “merged” timestamp strings for VehicleMQTTLocationResponse, including behavior when the nested Location payload is null.

Changes:

  • Add coverage for decoding a valid latestUpdateTime merged timestamp and asserting UTC date components.
  • Add a negative test ensuring invalid merged timestamp strings fail decoding.
  • Add a MergedDateFormatter round-trip test (string → date → string).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread KiaTests/VehicleMQTTLocationResponseTests.swift Outdated
Comment thread KiaTests/VehicleMQTTLocationResponseTests.swift Outdated
Comment thread KiaTests/VehicleMQTTLocationResponseTests.swift Outdated
@augard augard merged commit d31e1ff into main Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants