Skip to content

enhance resource anagement in Plotting Functions #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liincu4n wants to merge 1 commit into
base: main
Choose a base branch
from
Open

enhance resource anagement in Plotting Functions #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions deism/utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ def plot_RTFs(
# check if the length of P_all and P_labels are the same
if len(P_all) != len(P_labels):
raise ValueError("The number of RTFs and labels must match.")

# Limit input array size to prevent excessive memory usage
MAX_ARRAY_SIZE = 10_000_000 # Maximum array size
for p, f in zip(P_all, P_freqs):
if p.size > MAX_ARRAY_SIZE or f.size > MAX_ARRAY_SIZE:
raise ValueError(f"Input array size exceeds limit of {MAX_ARRAY_SIZE} elements.")

# Now use a few colors to plot the RTFs, black, gray, lightgray
colors = ["gray", "black", "lightgray", "red"]
linestypes = ["-", "-", "-.", "-"]
Expand Down Expand Up @@ -133,9 +140,9 @@ def plot_RTFs(
plt.savefig(fig_name, dpi=300, bbox_inches="tight")
# plt.savefig(fig_name_eps, bbox_inches="tight")
plt.savefig(fig_name_pdf, dpi=300, bbox_inches="tight")
plt.close("all")
else:
plt.show()
plt.close("all") # Always close figure to prevent memory leak

# Plot phases of the room transfer functions
fig = plt.figure(figsize=(18, 8))
Expand Down Expand Up @@ -181,9 +188,10 @@ def plot_RTFs(
plt.savefig(fig_name, dpi=300, bbox_inches="tight")
# plt.savefig(fig_name_eps, bbox_inches="tight")
plt.savefig(fig_name_pdf, dpi=300, bbox_inches="tight")
plt.close("all")

else:
plt.show()
plt.close("all") # Always close figure to prevent memory leak


def plot_results_LCs(
Expand All @@ -198,7 +206,11 @@ def plot_results_LCs(

# Set up latex for plotting
plt.rcParams["text.usetex"] = True

# Limit input array size to prevent excessive memory usage
MAX_ARRAY_SIZE = 10_000_000 # Maximum array size
if freqs.size > MAX_ARRAY_SIZE or P_DEISM_LC.size > MAX_ARRAY_SIZE or P_DEISM_LC_matrix.size > MAX_ARRAY_SIZE:
raise ValueError(f"Input array size exceeds limit of {MAX_ARRAY_SIZE} elements.")

# Initialize the SPL arrays
plot_mag_DEISM_LC = np.zeros_like(P_DEISM_LC, dtype="float")
plot_mag_DEISM_LC_matrix = np.zeros_like(P_DEISM_LC_matrix, dtype="float")
Expand Down