feat: sibling stops transfers - #75
Merged
Merged
Conversation
Contributor
|
Nice one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59
I see value in distinguishing between generated "sibling stops" (stops that share the same parent) transfers and cross-stop transfers. In Switzerland, it's tricky to rely on the virtual transfers logic #73 as without more complex routing logic it would create transfers between the start and end stops of vertical elevators, steep funiculars, etc. as they have a very short (sometimes 0) travel distance.
Thus, I propose to:
@matthiasfeist don't hesitate to let me know if you see a use-case where this sibling stops transfers logic is an issue - we can alternatively make it optional too. EDIT: I made it optional via a profile config already.
I also added support for the "forbidden transfers" which gets applied to prevent explicitly forbidden transfers from being generated.