Add json and yaml serialization for syncaggregatorselectiondata - #282
Open
jshufro wants to merge 4 commits into
Open
Add json and yaml serialization for syncaggregatorselectiondata#282jshufro wants to merge 4 commits into
jshufro wants to merge 4 commits into
Conversation
AntiD2ta
reviewed
Mar 17, 2026
AntiD2ta
requested changes
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Thanks a lot for the PR @jshufro !
I requested changes mainly for the test cases comment. The other two comments should be covered by a linter we will introduce soon.
Please also fix the linter reporting issues (we raised and merged a PR related to the linter issues that were not introduced in this PR. If you keep seeing pre-existing issues, try rebasing your branch with master).
Contributor
|
We will ignore the failing |
Co-authored-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.