fix(server): resolve Kimi provider lint and typecheck failures - #3
Closed
tarikermis wants to merge 1 commit into
Closed
fix(server): resolve Kimi provider lint and typecheck failures#3tarikermis wants to merge 1 commit into
tarikermis wants to merge 1 commit into
Conversation
- replace process.platform checks in Kimi tests with isHostWindows from @t3tools/shared/hostProcess (custom-oxlint rule) - drop unused EMPTY_CAPABILITIES in KimiProvider - Schema.UnknownFromJsonString -> Schema.fromJsonString(Schema.Unknown) - drop obsolete ["Service"] indexing on FileSystem/Path types in KimiProvider.test.ts
Author
|
Closing this since the upstream Kimi provider branch is no longer active after pingdotgg#5243 was closed. This patch only fixed lint and type errors on that feature branch, so there is nothing useful to rebase it onto now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs pingdotgg#5243
What changed
This fixes the lint and typecheck failures currently blocking the Kimi provider branch in
apps/server:process.platformchecks in the Kimi tests with the repository'sisHostWindowsabstraction.EMPTY_CAPABILITIESconstant.Schema.UnknownFromJsonStringAPI withSchema.fromJsonString(Schema.Unknown), matching the Claude and Grok adapters.["Service"]indexing from Effect filesystem and path types, and letwriteFakeKimiBinaryinfer its real error channel.preferSchemaOverJsononly for theJSON.stringifycall that writes the mock-agent JavaScript shim.These are compatibility and test-helper fixes only; provider behavior is unchanged.
Verification
Based on the current pingdotgg#5243 head (
a0b60ca4e):vp checkpasses.tsgo --noEmitpasses inapps/server; only existing suggestions remain insrc/orchestration/decider.ts.Windows paths are typechecked but were not run locally. The upstream workflow is still waiting for external-contributor approval, so the evidence here is from the equivalent local gates rather than a GitHub CI run.
I used Kimi Code for the implementation and Claude for a second review.
Checklist
Best Regards, Tarik