ci: bump action versions, enable runner triggers, update pre-commit and deps - #184
Open
atong01 wants to merge 1 commit into
Open
ci: bump action versions, enable runner triggers, update pre-commit and deps#184atong01 wants to merge 1 commit into
atong01 wants to merge 1 commit into
Conversation
…nd deps - python-publish.yml: actions/checkout@v3 -> v5, actions/setup-python@v3 -> v6 - test_runner.yaml: uncomment trigger block (aligned with test.yaml/code-quality.yaml pattern: push on main, PR on main + release/*), codecov-action@v3 -> v5 - test.yaml: codecov-action@v3 -> v5 - .pre-commit-config.yaml: pyupgrade --py38-plus -> --py39-plus, ruff v0.5.5 -> v0.6.9 - runner-requirements.txt: drop torch<2.0.0 upper bound, pytorch-lightning==1.8.3.post2 -> lightning, torchmetrics==0.11.0 -> torchmetrics - dependabot.yml: remove ignore rules for pytorch-lightning/torchmetrics patch updates (lightning 1.x is EOL)
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates CI workflows, pre-commit configuration, and runner dependencies to current versions while re-enabling the runner test workflow and removing outdated pins/ignore rules that blocked dependency updates. Flow diagram for updated CI workflows and runner test triggersflowchart TD
subgraph GitHub_Events
A[push to main]
B[pull_request to main or release/*]
end
subgraph Workflows
T[test.yaml workflow]
R[test_runner.yaml workflow]
P[python-publish.yml workflow]
end
subgraph External_Services
C["codecov-action@v5"]
PyPI[pypa/gh-action-pypi-publish]
end
A --> T
B --> T
A --> R
B --> R
T --> C
R --> C
A --> P
P --> PyPI
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- For the relaxed
torchandtorchmetricsconstraints inrunner-requirements.txt, consider using compatible version ranges (e.g.,torch>=2,<3,torchmetrics>=x,<y) instead of fully unpinning to reduce the risk of unexpected breaking changes in the runner. - Now that
pytorch-lightningis replaced bylightninginrunner-requirements.txt, it may be worth adding a brief TODO or issue reference near the remainingpytorch-lightningreferences (noted in the PR description) so the eventual code/config migration is easier to track.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- For the relaxed `torch` and `torchmetrics` constraints in `runner-requirements.txt`, consider using compatible version ranges (e.g., `torch>=2,<3`, `torchmetrics>=x,<y`) instead of fully unpinning to reduce the risk of unexpected breaking changes in the runner.
- Now that `pytorch-lightning` is replaced by `lightning` in `runner-requirements.txt`, it may be worth adding a brief TODO or issue reference near the remaining `pytorch-lightning` references (noted in the PR description) so the eventual code/config migration is easier to track.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates CI configuration: bumps outdated action versions, enables the runner test workflow, updates pre-commit hooks, and unpins outdated dependencies.
Changes
GitHub Actions versions
python-publish.yml:actions/checkout@v3→@v5,actions/setup-python@v3→@v6test.yaml:codecov-action@v3→@v5test_runner.yaml:codecov-action@v3→@v5; uncommented the trigger block (was fully commented out, so runner tests never ran on push/PR). Trigger pattern aligned withtest.yamlandcode-quality.yaml:push: [main],pull_request: [main, release/*].Pre-commit
.pre-commit-config.yaml:pyupgrade --py38-plus→--py39-plus(CI tests Python 3.9–3.13, so 3.8 floor was too conservative);ruff v0.5.5→v0.6.9Dependencies
runner-requirements.txt:torch<2.0.0upper bound (torch 2.x has been stable for a long time)pytorch-lightning==1.8.3.post2→lightning(thepytorch-lightningpackage name was deprecated in favor of the unifiedlightningpackage; 1.8.x is EOL)torchmetrics==0.11.0→torchmetrics(unpinned to allow compatible updates).github/dependabot.yml: removed theignore:block that suppressed patch updates forpytorch-lightningandtorchmetrics. With the migration tolightning, the old ignore rules no longer apply and would block useful updates.Motivation
Several CI workflow versions and pins were outdated. The runner test workflow triggers were fully commented out, so
runner/tests never actually ran in CI.pytorch-lightning1.8.x is EOL and the package was renamed. These updates bring CI back in line with current action versions and unblock future dependency updates.Validation
yaml.safe_load)codecov-action@v3,actions/checkout@v3,actions/setup-python@v3,==1.8.3,==0.11.0,<2.0.0,--py38-plus, orv0.5.5remain in any in-scope fileNotes
pypa/gh-action-pypi-publish@<SHA>pin inpython-publish.ymlwas left untouched (SHA-pinning is intentional for supply-chain security on publish workflows)runner/source files still referencepytorch-lightningin places (runner/tests/helpers/run_if.py,runner/configs/,runner/README.md) — these are out of scope for this CI-config PR and would be addressed separately if/when the runner is migrated tolightningSummary by Sourcery
Update CI workflows, pre-commit configuration, and runner dependencies to use current tooling and ensure runner tests execute in CI.
Enhancements:
Build:
CI: