Skip to content

refactor(gov): move oversight-DAO bundling check from the ante to a coredaos gov hook #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giunatale merged 3 commits into from
Jun 30, 2026
Merged

refactor(gov): move oversight-DAO bundling check from the ante to a coredaos gov hook #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc999c7
remove coredaos ante
giunatale Jun 29, 2026
85a839b
add gov hooks and edit VetoProposal msg
giunatale Jun 29, 2026
4c5d115
add CL entry and update go.mod
giunatale Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@

### IMPROVEMENTS

- migrate `x/coredaos` away from atomone `x/gov` wrapper [#353](https://github.com/atomone-hub/atomone/pull/353)
- Migrate `x/coredaos` away from atomone `x/gov` wrapper [#353](https://github.com/atomone-hub/atomone/pull/353)
- Move oversightDAO update bundling prevention from the ante to a coredaos gov hook [#354](https://github.com/atomone-hub/atomone/pull/354)

## v4.0.0

Expand Down
5 changes: 0 additions & 5 deletions ante/ante.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ type HandlerOptions struct {
PhotonKeeper *photonkeeper.Keeper
TxFeeChecker ante.TxFeeChecker
DynamicfeeKeeper *dynamicfeekeeper.Keeper
CoreDAOsKeeper CoredaosParamsGetter
}

func NewAnteHandler(opts HandlerOptions) (sdk.AnteHandler, error) {
Expand All @@ -53,9 +52,6 @@ func NewAnteHandler(opts HandlerOptions) (sdk.AnteHandler, error) {
if opts.DynamicfeeKeeper == nil {
return nil, errorsmod.Wrap(atomoneerrors.ErrNotFound, "dynamicfee keeper is required for AnteHandler")
}
if opts.CoreDAOsKeeper == nil {
return nil, errorsmod.Wrap(atomoneerrors.ErrNotFound, "coredaos keeper is required for AnteHandler")
}

sigGasConsumer := opts.SigGasConsumer
if sigGasConsumer == nil {
Expand Down Expand Up @@ -87,7 +83,6 @@ func NewAnteHandler(opts HandlerOptions) (sdk.AnteHandler, error) {
),
),
NewGovVoteDecorator(opts.Codec, opts.StakingKeeper),
NewGovSubmitProposalDecorator(opts.Codec, opts.CoreDAOsKeeper),
ibcante.NewRedundantRelayDecorator(opts.IBCkeeper),
}

Expand Down
132 changes: 0 additions & 132 deletions ante/gov_submit_proposal_ante.go
View file
Open in desktop

This file was deleted.

Loading
Loading