chore(x/staking): fix some typos and improve the code readability - #8
Merged
Conversation
Pantani
requested review from
giuliostramondo,
giunatale,
julienrbrt and
tbruyelle
as code owners
August 20, 2025 01:17
julienrbrt
approved these changes
Aug 20, 2025
julienrbrt
changed the title
tbruyelle
requested changes
Aug 20, 2025
tbruyelle
left a comment
tbruyelle
left a comment
Collaborator
There was a problem hiding this comment.
We need to address the usage of the maps and slices package vs the declared go version in go.mod. Other than that only a couple of small suggestions/question.
Pantani
commented
Aug 20, 2025
Pantani
force-pushed
the
chore/fix-some-staking-typos
branch
3 times, most recently
from
August 22, 2025 18:48
537f382 to
c4042ae
Compare
Pantani
force-pushed
the
chore/fix-some-staking-typos
branch
from
August 22, 2025 18:52
c4042ae to
6a87672
Compare
julienrbrt
approved these changes
Aug 24, 2025
giunatale
approved these changes
Aug 25, 2025
…some-staking-typos # Conflicts: # .golangci.yml # x/staking/keeper/delegation.go # x/staking/keeper/slash.go # x/staking/keeper/val_state_change.go # x/staking/module.go
Pantani
enabled auto-merge (squash)
September 1, 2025 22:14
Pantani
disabled auto-merge
September 15, 2025 23:48
Pantani
enabled auto-merge (squash)
September 15, 2025 23:48
tbruyelle
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting all fixes and changes from the main branch of the staking module in the cosmos-sdk repo